Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

Issue 1719103002: CacheStorage: Expand cache.keys() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
index 0d39207686eb2f39d9252a6c3c0b517d7a3aa349..17a4d7cb1ad082d581f5d12afd637942f21e896e 100644
--- a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
+++ b/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
@@ -131,11 +131,11 @@ public:
return callbacks->onError(m_error);
}
- void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest* webRequest, const QueryParams& queryParams) override
+ void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
{
m_lastErrorWebCacheMethodCalled = "dispatchKeys";
- if (webRequest) {
- checkUrlIfProvided(webRequest->url());
+ if (!webRequest.url().isEmpty()) {
+ checkUrlIfProvided(webRequest.url());
checkQueryParamsIfProvided(queryParams);
}
@@ -513,7 +513,7 @@ public:
KeysTestCache(WebVector<WebServiceWorkerRequest>& requests)
: m_requests(requests) { }
- void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest* webRequest, const QueryParams& queryParams) override
+ void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
{
std::unique_ptr<CacheWithRequestsCallbacks> ownedCallbacks(wrapUnique(callbacks));
return callbacks->onSuccess(m_requests);

Powered by Google App Engine
This is Rietveld 408576698