third_party/WebKit/Source/modules/cachestorage/Cache.cpp - Issue 1719103002: CacheStorage: Expand cache.keys() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/Cache.cpp

Issue 1719103002: CacheStorage: Expand cache.keys() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/cachestorage/Cache.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp

index 1ec10966bd64c9cf798c662a3f088b047ea67c07..24d45aa1a61c6561a9902c504d300250b445968a 100644

--- a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp

@@ -604,7 +604,7 @@ ScriptPromise Cache::keysImpl(ScriptState* scriptState)

{

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

const ScriptPromise promise = resolver->promise();

- m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, WebServiceWorkerCache::QueryParams());

+ m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), WebServiceWorkerRequest(), WebServiceWorkerCache::QueryParams());

return promise;

}

@@ -616,7 +616,7 @@ ScriptPromise Cache::keysImpl(ScriptState* scriptState, const Request* request,

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

const ScriptPromise promise = resolver->promise();

- m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, toWebQueryParams(options));

+ m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), webRequest, toWebQueryParams(options));

return promise;

}