DescriptionRe-upload of https://codereview.chromium.org/1673183002/.
Enable H.264 video WebRTC behind run-time flag and add
WebRtcBrowserTest for H.264.
The compile flag |rtc_use_h264| defaults to
|proprietary_codecs| which is used on some Chromium bots
and in the official Chrome build. The new run-time flag
|kWebRtcH264WithOpenH264FFmpeg| determines if the
|rtc_use_h264| encoder/decoder will be used at runtime.
The run-time flag is off by default.
This CL:
- Adds run-time flag and a new build target for it. It is
placed in content/public/common/ because it
can't/shouldn't be placed in the webrtc repo and
peer_connection_dependency_factory.cc lives in
content/renderer/media/webrtc/.
- Moves renderer_features and its generated header file
target from content/renderer/ to content/public/common/
to not break include rules and renames it to
common_features.
- Based on the run-time flag, enables or disables H.264
in peer_connection_dependency_factory.cc.
- If flag is on, runs a new H.264 browser test.
BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/b43b719e4e54f569eeefd2beb85517d75bf6cbfd
Cr-Commit-Position: refs/heads/master@{#377556}
Patch Set 1 #Patch Set 2 : browser_tests and content_renderer depending on common_features directly (prev indirect dep) #Patch Set 3 : ('dependencies' instead of 'deps') #
Total comments: 2
Patch Set 4 : Renamed base::Feature name to match follow-up CL study name #Patch Set 5 : content_common.gypi depending on common_features #
Total comments: 4
Patch Set 6 : Addressed brettw comments (remove colon and gen header from list) #
Total comments: 7
Patch Set 7 : Addressed brettw comments (adding to deps instead of removing) #Patch Set 8 : Addressed brettw comments (removed LOG) #Patch Set 9 : Rebase with master #Patch Set 10 : common_features.h -> features.h + GN common_features -> features rename #Patch Set 11 : (Updated comment) #
Messages
Total messages: 40 (12 generated)
|