mojo filesystem: Further clean ups.

mojo filesystem: Further clean ups.

- Cleans up pieces that I partially, but didn't fully delete in the last
  patch.
- Changes the FileSystem interface so that there isn't a free form string
  in in.
- Separates out the current mandoline directory choosing code into the app
  impl instead of the service impl. This should let us make a chrome version
  in a future patch.

BUG=585587
Committed: https://crrev.com/7e3aa65e323f57adca2b8774a4f1612dace33c70
Cr-Commit-Position: refs/heads/master@{#377058}

[Elliot Glaysher, 2016-02-23 00:46:47]

erg@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-02-23 16:51:25]

lgtm

https://codereview.chromium.org/1718123004/diff/20001/components/filesystem/f...
File components/filesystem/file_system_impl.h (right):

https://codereview.chromium.org/1718123004/diff/20001/components/filesystem/f...
components/filesystem/file_system_impl.h:32: base::FilePath user_data_dir,
nit: add comment to this constructor explaining the arguments.

in particular, user_data_dir should be explained and probably renamed. since
this is a generic component, it seems like it shouldn't know about profiles and
user data dir. can it just be "directory"?

[Elliot Glaysher, 2016-02-23 18:11:19]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-02-23 18:11:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1718123004/#ps40001
(title: "jam comments")

[commit-bot: I haz the power, 2016-02-23 18:13:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718123004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718123004/40001

[commit-bot: I haz the power, 2016-02-23 19:43:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 19:44:44]

Description was changed from

==========
mojo filesystem: Further clean ups.

- Cleans up pieces that I partially, but didn't fully delete in the last
  patch.
- Changes the FileSystem interface so that there isn't a free form string
  in in.
- Separates out the current mandoline directory choosing code into the app
  impl instead of the service impl. This should let us make a chrome version
  in a future patch.

BUG=585587
==========

to

==========
mojo filesystem: Further clean ups.

- Cleans up pieces that I partially, but didn't fully delete in the last
  patch.
- Changes the FileSystem interface so that there isn't a free form string
  in in.
- Separates out the current mandoline directory choosing code into the app
  impl instead of the service impl. This should let us make a chrome version
  in a future patch.

BUG=585587

Committed: https://crrev.com/7e3aa65e323f57adca2b8774a4f1612dace33c70
Cr-Commit-Position: refs/heads/master@{#377058}
==========

[commit-bot: I haz the power, 2016-02-23 19:44:45]

Patchset 3 (id:??) landed as
https://crrev.com/7e3aa65e323f57adca2b8774a4f1612dace33c70
Cr-Commit-Position: refs/heads/master@{#377058}