Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/filesystem/public/interfaces/file_system.mojom

Issue 1718123004: mojo filesystem: Further clean ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: jam comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/files_test_base.cc ('k') | components/leveldb/leveldb_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/public/interfaces/file_system.mojom
diff --git a/components/filesystem/public/interfaces/file_system.mojom b/components/filesystem/public/interfaces/file_system.mojom
index 72785636ddaf92159f1375431f8eedd8916ad1b0..db72679d2e732d6ab0a8fc6349de37388a81800d 100644
--- a/components/filesystem/public/interfaces/file_system.mojom
+++ b/components/filesystem/public/interfaces/file_system.mojom
@@ -7,21 +7,11 @@ module filesystem;
import "components/filesystem/public/interfaces/directory.mojom";
import "components/filesystem/public/interfaces/types.mojom";
-// Callback interface for FileSystem. When we call OpenFileSystem, we supply a
-// client to receive and handle the shutdown signal. Just because the shell has
-// closed the application connection to the FileSystem doesn't mean that we
-// should immediately kill all connections to our clients. We notify them that
-// we are shutting down so that they can flush any data and cleanly shutdown.
-//
-// Actual connection lifetime is controlled by the lifetime of the |directory|
-// object.
-interface FileSystemClient {
- OnFileSystemShutdown();
-};
-
interface FileSystem {
- // Opens the root directory for the file system with the given name; null
- // yields the default file system, if any.
- OpenFileSystem(string? file_system, Directory& directory,
- FileSystemClient client) => (FileError error);
+ // Opens a temporary filesystem. Will return a different directory each time
+ // it is called.
+ OpenTempDirectory(Directory& directory) => (FileError error);
+
+ // Returns a directory which will persist to disk.
+ OpenPersistentFileSystem(Directory& directory) => (FileError error);
};
« no previous file with comments | « components/filesystem/files_test_base.cc ('k') | components/leveldb/leveldb_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698