Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1718093006: Limit the set of Visual Studio projects generated by GN (Closed)

Created:
4 years, 10 months ago by Tomasz Moniuszko
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit the set of Visual Studio projects generated by GN BUG=589099 Committed: https://crrev.com/014e81d144453d840e09eb9695b0dee262bc3507 Cr-Commit-Position: refs/heads/master@{#377871}

Patch Set 1 #

Patch Set 2 : Fix filter path correction #

Total comments: 8

Patch Set 3 : Use label patterns + gen command help fixes #

Total comments: 2

Patch Set 4 : Rebase onto current master + review and comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -19 lines) Patch
M tools/gn/command_gen.cc View 1 2 5 chunks +32 lines, -9 lines 0 comments Download
M tools/gn/visual_studio_writer.h View 1 2 3 3 chunks +11 lines, -5 lines 0 comments Download
M tools/gn/visual_studio_writer.cc View 1 2 3 5 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Tomasz Moniuszko
4 years, 10 months ago (2016-02-23 13:49:26 UTC) #2
brettw
https://codereview.chromium.org/1718093006/diff/20001/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/1718093006/diff/20001/tools/gn/command_gen.cc#newcode217 tools/gn/command_gen.cc:217: "GN optionally generates files for IDEs. Possibilities for <ide ...
4 years, 10 months ago (2016-02-24 22:11:26 UTC) #3
Tomasz Moniuszko
https://codereview.chromium.org/1718093006/diff/20001/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/1718093006/diff/20001/tools/gn/command_gen.cc#newcode217 tools/gn/command_gen.cc:217: "GN optionally generates files for IDEs. Possibilities for <ide ...
4 years, 10 months ago (2016-02-25 13:28:20 UTC) #4
brettw
much nicer, lgtm https://codereview.chromium.org/1718093006/diff/40001/tools/gn/visual_studio_writer.cc File tools/gn/visual_studio_writer.cc (right): https://codereview.chromium.org/1718093006/diff/40001/tools/gn/visual_studio_writer.cc#newcode233 tools/gn/visual_studio_writer.cc:233: for (std::string& token : tokens) { ...
4 years, 10 months ago (2016-02-25 22:38:33 UTC) #5
Tomasz Moniuszko
https://codereview.chromium.org/1718093006/diff/40001/tools/gn/visual_studio_writer.cc File tools/gn/visual_studio_writer.cc (right): https://codereview.chromium.org/1718093006/diff/40001/tools/gn/visual_studio_writer.cc#newcode233 tools/gn/visual_studio_writer.cc:233: for (std::string& token : tokens) { On 2016/02/25 22:38:33, ...
4 years, 10 months ago (2016-02-26 11:47:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718093006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718093006/60001
4 years, 10 months ago (2016-02-26 11:47:37 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-26 12:25:04 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 12:26:35 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/014e81d144453d840e09eb9695b0dee262bc3507
Cr-Commit-Position: refs/heads/master@{#377871}

Powered by Google App Engine
This is Rietveld 408576698