Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: tools/gn/visual_studio_writer.h

Issue 1718093006: Limit the set of Visual Studio projects generated by GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase onto current master + review and comment fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_gen.cc ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.h
diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h
index 6950dd68e2147bd00bfb7e6a14ed42cbd4251978..5b578ed3cbab3b968672fc707ed60d0c0cf373e3 100644
--- a/tools/gn/visual_studio_writer.h
+++ b/tools/gn/visual_studio_writer.h
@@ -29,10 +29,16 @@ class VisualStudioWriter {
Vs2015 // Visual Studio 2015
};
- // On failure will populate |err| and will return false.
+ // Writes Visual Studio project and solution files. |sln_name| is the optional
+ // solution file name ("all" is used if not specified). |dir_filters| is
+ // optional semicolon-separated list of label patterns used to limit the set
+ // of generated projects. Only matching targets will be included to the
+ // solution. On failure will populate |err| and will return false.
static bool RunAndWriteFiles(const BuildSettings* build_settings,
Builder* builder,
Version version,
+ const std::string& sln_name,
+ const std::string& dir_filters,
Err* err);
private:
@@ -74,9 +80,9 @@ class VisualStudioWriter {
using SolutionProjects = std::vector<SolutionProject*>;
using SolutionFolders = std::vector<SolutionEntry*>;
- explicit VisualStudioWriter(const BuildSettings* build_settings,
- const char* config_platform,
- Version version);
+ VisualStudioWriter(const BuildSettings* build_settings,
+ const char* config_platform,
+ Version version);
~VisualStudioWriter();
bool WriteProjectFiles(const Target* target, Err* err);
@@ -85,7 +91,7 @@ class VisualStudioWriter {
const Target* target,
Err* err);
void WriteFiltersFileContents(std::ostream& out, const Target* target);
- bool WriteSolutionFile(Err* err);
+ bool WriteSolutionFile(const std::string& sln_name, Err* err);
void WriteSolutionFileContents(std::ostream& out,
const base::FilePath& solution_dir_path);
« no previous file with comments | « tools/gn/command_gen.cc ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698