Re-order unregistration and detachment of failed ScriptLoader.

Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=haraken
BUG=570012
Committed: https://crrev.com/7a9420fd2fdbe2fa057e31cb9ed308e531a079e1
Cr-Commit-Position: refs/heads/master@{#376986}

[sof, 2016-02-23 13:51:19]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org

[sof, 2016-02-23 13:51:20]

please take a look.

We're seeing this dreadful crash stack in M50 also on our side, so I think
something needs to be done. Based on debugging this one via crashdumps a bit,
this change _might_ address it.

[haraken, 2016-02-23 13:53:19]

LGTM

[sof, 2016-02-23 14:46:44]

Description was changed from

==========
Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=
BUG=570012
==========

to

==========
Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=haraken
BUG=570012
==========

[sof, 2016-02-23 15:20:23]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-02-23 15:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718083005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718083005/1

[commit-bot: I haz the power, 2016-02-23 15:25:46]

Description was changed from

==========
Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=haraken
BUG=570012
==========

to

==========
Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=haraken
BUG=570012
==========

[commit-bot: I haz the power, 2016-02-23 15:25:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-23 15:27:11]

Description was changed from

==========
Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=haraken
BUG=570012
==========

to

==========
Re-order unregistration and detachment of failed ScriptLoader.

For a ScriptLoader that fails to load its script resource, unregister
with the associated ScriptRunner before dispatching 'error'. This avoids
potential trouble should the onerror handler trigger nested access to
the ScriptRunner's (sync) script queue, if it ends up loading script
resources of its own.

R=haraken
BUG=570012

Committed: https://crrev.com/7a9420fd2fdbe2fa057e31cb9ed308e531a079e1
Cr-Commit-Position: refs/heads/master@{#376986}
==========

[commit-bot: I haz the power, 2016-02-23 15:27:11]

Patchset 1 (id:??) landed as
https://crrev.com/7a9420fd2fdbe2fa057e31cb9ed308e531a079e1
Cr-Commit-Position: refs/heads/master@{#376986}