third_party/WebKit/Source/core/dom/ScriptRunner.cpp - Issue 1718083005: Re-order unregistration and detachment of failed ScriptLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

Issue 1718083005: Re-order unregistration and detachment of failed ScriptLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

index c10c779a8dbf1a00c9c7e3f6b24e302c87fd7726..b3312a67b0f96deb50833694fcf4bc388d614f66 100644

--- a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

@@ -223,7 +223,6 @@ void ScriptRunner::notifyScriptLoadError(ScriptLoader* scriptLoader, ExecutionTy

RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(foundLoader);

break;

}

- scriptLoader->detach();

m_document->decrementLoadEventDelayCount();

}

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('k') | no next file » | no next file with comments »