Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: BUILD.gn

Issue 1718073002: Remove the 'ios_use_webrtc' build flag hack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix string_provider reference and comment out other ios targets for now Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index c9d40e87cfe543a9b6d0f89b0981586ed96b5a31..94ecdfc54023ff5b368832974d23ccbaadc105bd 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -12,7 +12,6 @@ import("//build/config/features.gni")
import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//build_overrides/v8.gni")
-import("//build_overrides/webrtc.gni")
import("//media/media_options.gni")
import("//third_party/openh264/openh264_args.gni")
@@ -199,22 +198,17 @@ group("both_gn_and_gyp") {
]
} else {
deps += [
+ #"//ios/chrome:ios_chrome_unittests", TODO(GYP)
+ #"//ios/chrome/app", TODO(GYP)
+ #"//ios/chrome/browser", TODO(GYP)
+ "//ios/chrome/common",
"//ios/net:ios_net_unittests",
+ "//ios/public/provider/chrome/browser",
"//ios/public/provider/web",
"//ios/testing:ocmock_support_unittest",
"//ios/web:ios_web_unittests",
"//ios/web/shell:ios_web_shell",
]
-
- if (ios_use_webrtc) {
- deps += [
- "//ios/chrome:ios_chrome_unittests",
- "//ios/chrome/app",
- "//ios/chrome/browser",
- "//ios/chrome/common",
- "//ios/public/provider/chrome/browser",
- ]
- }
}
deps += root_extra_deps
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698