content/browser/android/download_controller_android_impl.h - Issue 1717783002: Fix an issue that download filename from content disposition is not sanitized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/download_controller_android_impl.h

Issue 1717783002: Fix an issue that download filename from content disposition is not sanitized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass localized default download file name Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/download/download_manager_service.cc ('K') | « chrome/browser/android/download/download_manager_service.cc ('k') | content/browser/android/download_controller_android_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/download_controller_android_impl.h

diff --git a/content/browser/android/download_controller_android_impl.h b/content/browser/android/download_controller_android_impl.h

index 386135e00cced06d46587e6ea533fe86f42998f1..9045d2992efa5418b2ee733f041c70061aa193fe 100644

--- a/content/browser/android/download_controller_android_impl.h

+++ b/content/browser/android/download_controller_android_impl.h

@@ -59,6 +59,7 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid {

void AcquireFileAccessPermission(

WebContents* web_contents,

const AcquireFileAccessPermissionCallback& callback) override;

+ void SetDefaultDownloadFileName(const std::string& file_name) override;

private:

// Used to store all the information about an Android download.

@@ -142,6 +143,8 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid {

JavaObject* java_object_;

+ std::string default_file_name_;

ScopedVector<DeferredDownloadObserver> deferred_downloads_;

DISALLOW_COPY_AND_ASSIGN(DownloadControllerAndroidImpl);