Fix an issue that download filename from content disposition is not sanitized

chrome/browser/android/download/download_manager_service.cc

Index: chrome/browser/android/download/download_manager_service.cc
diff --git a/chrome/browser/android/download/download_manager_service.cc b/chrome/browser/android/download/download_manager_service.cc
index b52fe1ee799c8f030b31fc42d7fa5af72f033695..0e0ed618c7b49f925847e6da9b82c766834074fc 100644
--- a/chrome/browser/android/download/download_manager_service.cc
+++ b/chrome/browser/android/download/download_manager_service.cc
@@ -8,10 +8,12 @@
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/grit/generated_resources.h"
 #include "content/public/browser/android/download_controller_android.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/download_item.h"
 #include "jni/DownloadManagerService_jni.h"
+#include "ui/base/l10n/l10n_util.h"
 
 using base::android::JavaParamRef;
 using base::android::ConvertJavaStringToUTF8;
@@ -45,6 +47,8 @@ DownloadManagerService::DownloadManagerService(
     jobject obj,
     content::DownloadManager* manager)
     : java_ref_(env, obj), manager_(manager) {
+  content::DownloadControllerAndroid::Get()->SetDefaultDownloadFileName(
+      l10n_util::GetStringUTF8(IDS_DEFAULT_DOWNLOAD_FILENAME));

[asanka, 2016/02/24 20:04:44]

Why can't DownloadControllerAndroid do this on its own?

[qinmin, 2016/02/24 21:56:06]

2 reasons:
1. IDS_DEFAULT_DOWNLOAD_FILENAME is in chrome/, instead of content/
2. l10n_util is in ui/base, and content/ doesn't depend on that

DownloadManagerService are initialized at browser start up, so it can pass the
localized string from chrome/ to content/

[asanka, 2016/02/24 22:08:03]

Ah. I overlooked the fact that DownloadControllerAndroid is in //content.

   manager_->AddObserver(this);
 }