Only run Java checkstyle on Upload and not Submit.

Only run Java checkstyle on Upload and not Submit.

BUG=None
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252207

[aurimas (slooooooooow), 2014-02-19 19:53:56]

Hey Newton,

Please take a look at this cl.

Aurimas

[newt (away), 2014-02-19 19:55:46]

lgtm

[nyquist, 2014-02-19 20:13:02]

How long time does it take to run checkstyle presubmit? Does it add a lot of
overhead for the upload step?

Could we instead fail gracefully if checkstyle is not available? It's nice if
checkstyle checks are done on the bots and not only locally.

[newt (away), 2014-02-19 20:45:30]

On 2014/02/19 20:13:02, nyquist wrote:
> How long time does it take to run checkstyle presubmit? Does it add a lot of
> overhead for the upload step?

~1 second. Checkstyle currently runs during upload and on presubmit. This just
stops running checkstyle during presubmit.

> Could we instead fail gracefully if checkstyle is not available? It's nice if
> checkstyle checks are done on the bots and not only locally.

[aurimas (slooooooooow), 2014-02-19 22:08:13]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2014-02-19 22:08:17]

The CQ bit was unchecked by aurimas@chromium.org

[aurimas (slooooooooow), 2014-02-19 22:08:34]

+maruel for OWNERS review.

[M-A Ruel, 2014-02-19 22:09:35]

lgtm

[aurimas (slooooooooow), 2014-02-19 22:11:21]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-02-19 22:15:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/171773007/1

[commit-bot: I haz the power, 2014-02-20 00:51:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/171773007/1

[aurimas (slooooooooow), 2014-02-20 02:20:12]

The CQ bit was unchecked by aurimas@chromium.org

[aurimas (slooooooooow), 2014-02-20 02:20:19]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-02-20 04:42:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/171773007/1

[commit-bot: I haz the power, 2014-02-20 08:47:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/171773007/1

[commit-bot: I haz the power, 2014-02-20 12:20:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/171773007/1

[commit-bot: I haz the power, 2014-02-20 13:09:39]

Change committed as 252207