PRESUBMIT.py - Issue 171773007: Only run Java checkstyle on Upload and not Submit. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(267)

My Issues | Starred Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 171773007: Only run Java checkstyle on Upload and not Submit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 4dd44ca177104227aacdfb9c000907f6f9b4b455..78d9e167b3c0e1ccef68860ca80653029b981f61 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1060,7 +1060,6 @@ def _CommonChecks(input_api, output_api):

results.extend(_CheckSpamLogging(input_api, output_api))

results.extend(_CheckForAnonymousVariables(input_api, output_api))

results.extend(_CheckCygwinShell(input_api, output_api))

- results.extend(_CheckJavaStyle(input_api, output_api))

if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):

results.extend(input_api.canned_checks.RunUnitTestsInDirectory(

@@ -1206,6 +1205,7 @@ def _CheckForInvalidOSMacros(input_api, output_api):

def CheckChangeOnUpload(input_api, output_api):

results = []

results.extend(_CommonChecks(input_api, output_api))

+ results.extend(_CheckJavaStyle(input_api, output_api))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698