Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 171763004: Remove pp_ifdef from resource files in chrome/browser and chrome/renderer. (Closed)

Created:
6 years, 10 months ago by newt (away)
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove pp_ifdef from resource files in chrome/browser and chrome/renderer. Generated using: > git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g" BUG=343235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251987

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed artisanal comments from #1 #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -150 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 20 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/resources/about_version.html View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 10 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/resources/components.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/pack_extension_overlay.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/html/default.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/flags.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/help/help.html View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/help/help.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 26 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/resources/options/certificate_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/language_options.html View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/options.html View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/sync_section.html View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/plugins.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/renderer/resources/plugin_placeholders.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
newt (away)
PTAL, thanks!
6 years, 10 months ago (2014-02-19 01:03:36 UTC) #1
Nico
Handcrafted artisan lgtm https://codereview.chromium.org/171763004/diff/1/chrome/browser/resources/options/content_settings.html File chrome/browser/resources/options/content_settings.html (right): https://codereview.chromium.org/171763004/diff/1/chrome/browser/resources/options/content_settings.html#newcode414 chrome/browser/resources/options/content_settings.html:414: <if expr="chromeos"> Should this be indented ...
6 years, 10 months ago (2014-02-19 01:08:43 UTC) #2
newt (away)
https://codereview.chromium.org/171763004/diff/1/chrome/browser/resources/options/content_settings.html File chrome/browser/resources/options/content_settings.html (right): https://codereview.chromium.org/171763004/diff/1/chrome/browser/resources/options/content_settings.html#newcode414 chrome/browser/resources/options/content_settings.html:414: <if expr="chromeos"> On 2014/02/19 01:08:43, Nico wrote: > Should ...
6 years, 10 months ago (2014-02-19 01:43:15 UTC) #3
Nico
Thanks! https://codereview.chromium.org/171763004/diff/1/chrome/browser/resources/options/content_settings.html File chrome/browser/resources/options/content_settings.html (right): https://codereview.chromium.org/171763004/diff/1/chrome/browser/resources/options/content_settings.html#newcode414 chrome/browser/resources/options/content_settings.html:414: <if expr="chromeos"> On 2014/02/19 01:43:15, newt wrote: > ...
6 years, 10 months ago (2014-02-19 01:44:50 UTC) #4
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 10 months ago (2014-02-19 02:11:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/171763004/170001
6 years, 10 months ago (2014-02-19 02:12:17 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:03:39 UTC) #7
Message was sent while issue was closed.
Change committed as 251987

Powered by Google App Engine
This is Rietveld 408576698