Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 171763004: Remove pp_ifdef from resource files in chrome/browser and chrome/renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/feedback/html/default.html ('k') | chrome/browser/resources/flags.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/feedback/js/feedback.js
diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js
index 17d361be9e7b4738df82356ba51b2ba54cceefb9..e87b26c98e975b2a369218d59331df3601b40ace 100644
--- a/chrome/browser/resources/feedback/js/feedback.js
+++ b/chrome/browser/resources/feedback/js/feedback.js
@@ -140,7 +140,7 @@ function sendReport() {
// Send histograms along with system info.
useSystemInfo = useHistograms = true;
}
-<if expr="pp_ifdef('chromeos')">
+<if expr="chromeos">
if ($('performance-info-checkbox') == null ||
!($('performance-info-checkbox').checked)) {
feedbackInfo.traceId = null;
@@ -196,7 +196,7 @@ function dataUrlToBlob(url) {
return new Blob([new Uint8Array(dataArray)], {type: mimeString});
}
-<if expr="pp_ifdef('chromeos')">
+<if expr="chromeos">
/**
* Update the page when performance feedback state is changed.
*/
@@ -291,7 +291,7 @@ function initialize() {
$('attach-file').hidden = true;
}
-<if expr="pp_ifdef('chromeos')">
+<if expr="chromeos">
if (feedbackInfo.traceId && ($('performance-info-area'))) {
$('performance-info-area').hidden = false;
$('performance-info-checkbox').checked = true;
@@ -329,7 +329,7 @@ function initialize() {
$('send-report-button').onclick = sendReport;
$('cancel-button').onclick = cancel;
$('remove-attached-file').onclick = clearAttachedFile;
-<if expr="pp_ifdef('chromeos')">
+<if expr="chromeos">
$('performance-info-checkbox').addEventListener(
'change', performanceFeedbackChanged);
</if>
« no previous file with comments | « chrome/browser/resources/feedback/html/default.html ('k') | chrome/browser/resources/flags.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698