Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1717603005: GN: Update Windows SDK version to 10586 in generated project files (Closed)

Created:
4 years, 10 months ago by NGG
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Update Windows SDK version to 10586 in generated project files It has already been updated to 10.0.10586.0 in other places in the following CLs: https://codereview.chromium.org/1608013002 https://codereview.chromium.org/1615603002 R=brettw@chromium.org BUG= Committed: https://crrev.com/687b6f3a94311da0094cc942413a9faef80d0b29 Cr-Commit-Position: refs/heads/master@{#376857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/visual_studio_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
NGG
4 years, 10 months ago (2016-02-20 17:27:14 UTC) #1
brettw
lgtm
4 years, 10 months ago (2016-02-22 23:11:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717603005/1
4 years, 10 months ago (2016-02-22 23:14:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 23:52:08 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 23:53:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/687b6f3a94311da0094cc942413a9faef80d0b29
Cr-Commit-Position: refs/heads/master@{#376857}

Powered by Google App Engine
This is Rietveld 408576698