Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1608013002: Change default Win10 SDK from 10240 to 10586 (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, penny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change default Win10 SDK from 10240 to 10586 When Chromium switched to the Windows 10 SDK it specified the 10240 version but this is missing IVirtualDesktopManager and other types. This doesn't affect VS 2015 builds because the package the 10586 SDK, but it does affect builds where DEPOT_TOOLS_WIN_TOOLCHAIN=0 is set. This change updates the local-toolchain builds to require the 10586 SDK. Developers are responsible for installing it. BUG=491424, 516306 Committed: https://crrev.com/bc8f4fcbcb068a82877fcd44cacaa352bcc935e0 Cr-Commit-Position: refs/heads/master@{#370252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M build/common.gypi View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
brucedawson
Can you take a look? It looks like an oversight that this wasn't updated earlier ...
4 years, 11 months ago (2016-01-19 20:34:17 UTC) #3
scottmg
lgtm. I just removed metro_driver elsewhere.
4 years, 11 months ago (2016-01-19 20:42:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608013002/1
4 years, 11 months ago (2016-01-19 22:06:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 01:11:56 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 01:14:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc8f4fcbcb068a82877fcd44cacaa352bcc935e0
Cr-Commit-Position: refs/heads/master@{#370252}

Powered by Google App Engine
This is Rietveld 408576698