[CSS Regions] Add new regionOversetChange event

[CSS Regions] Add new regionOversetChange event

Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again, there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.

BUG=252231
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152900

[apavlov, 2013-06-21 15:43:06]

LGTM with nits.

Please fix the style prior to landing.

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
File LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html (right):

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html:14:
overflow:hidden;
We normally have a whitespace after ':' in property declarations

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html:70:
++eventFiredCount;
Odd indentation

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html:73: // wait
and make sure no other events arrive
// Comments should be full sentences.
See [comments-sentences] at www.chromium.org/blink/coding-style

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
File
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html
(right):

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html:14:
overflow:hidden;
We normally have a whitespace after ':' in property declarations

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html:59:

This blank line is not necessary at the start of the SCRIPT tag contents

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html:80:
function EnableFlexbox() {
Function names should be camelCasedLikeThis() (which is correct elsewhere)
See [names-basic] at www.chromium.org/blink/coding-style

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html:84:
// wait and make sure no other events arrive
// Comments should be full sentences.
See [comments-sentences] at www.chromium.org/blink/coding-style

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html:89:
++eventFiredCount;
Odd indentation

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html:92:
// activate the flexbox
[comments-sentences] at www.chromium.org/blink/coding-style

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
File
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html
(right):

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html:14:
overflow:hidden;
whitespace after ':'

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html:62:

optional: blank line

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html:83:
function EnableFlexbox() {
enableFlexbox()

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html:89:
++eventFiredCount;
indentation

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html:92:
// activate the flexbox
// Activate the flexbox.

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
File LayoutTests/fast/regions/webkit-named-flow-event-target.html (right):

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-target.html:89:
event.target.removeEventListener("webkitregionoversetchange",
flowThreadUpdated);
Please replace tabs by spaces at the beginning of this line, while we are here

https://codereview.chromium.org/17176018/diff/1/LayoutTests/fast/regions/webk...
LayoutTests/fast/regions/webkit-named-flow-event-target.html:91:
setTimeout("finishTest()", 200);
Ditto

https://codereview.chromium.org/17176018/diff/1/Source/core/rendering/RenderF...
File Source/core/rendering/RenderFlowThread.h (right):

https://codereview.chromium.org/17176018/diff/1/Source/core/rendering/RenderF...
Source/core/rendering/RenderFlowThread.h:129: bool previousRegionCountChanged()
const { return m_previousRegionCount != m_regionList.size(); };
Please remove the ';' after '}'

https://codereview.chromium.org/17176018/diff/1/Source/core/rendering/RenderF...
Source/core/rendering/RenderFlowThread.h:130: void updatePreviousRegionCount() {
m_previousRegionCount = m_regionList.size(); };
Ditto

[commit-bot: I haz the power, 2013-06-21 16:38:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stavila@adobe.com/17176018/6001

[commit-bot: I haz the power, 2013-06-21 18:33:13]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-06-21 18:46:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stavila@adobe.com/17176018/6001

[commit-bot: I haz the power, 2013-06-21 19:27:02]

Change committed as 152900