Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 17176012: Remove NULL ResourceProvider, TileManager early outs (Closed)

Created:
7 years, 6 months ago by boliu
Modified:
7 years, 6 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, aelias_OOO_until_Jul13, joth
Visibility:
Public.

Description

Remove NULL ResourceProvider, TileManager early outs These early outs were added in r201247 as part of resourceless software mode in which ResourceProvider and TileManager were not created. This is no longer the case after r207424, so remove these early outs. For Android WebView, this does not affect software mode, and does not make hardware any more broken than it already is. BUG=245935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207673

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -46 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 7 chunks +19 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
boliu
https://codereview.chromium.org/17176012/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (left): https://codereview.chromium.org/17176012/diff/1/cc/trees/layer_tree_host_impl.cc#oldcode754 cc/trees/layer_tree_host_impl.cc:754: if (renderer_) { I'm not sure why this was ...
7 years, 6 months ago (2013-06-20 17:13:53 UTC) #1
danakj
LGTM https://codereview.chromium.org/17176012/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/17176012/diff/1/cc/trees/layer_tree_host_impl.cc#newcode752 cc/trees/layer_tree_host_impl.cc:752: if (!output_surface_->ForcedDrawToSoftwareDevice()) Should this go away (in another ...
7 years, 6 months ago (2013-06-20 18:00:33 UTC) #2
boliu
https://codereview.chromium.org/17176012/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/17176012/diff/1/cc/trees/layer_tree_host_impl.cc#newcode752 cc/trees/layer_tree_host_impl.cc:752: if (!output_surface_->ForcedDrawToSoftwareDevice()) On 2013/06/20 18:00:33, danakj wrote: > Should ...
7 years, 6 months ago (2013-06-20 21:01:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/17176012/5001
7 years, 6 months ago (2013-06-20 21:02:41 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 02:49:30 UTC) #5
Message was sent while issue was closed.
Change committed as 207673

Powered by Google App Engine
This is Rietveld 408576698