Introduce BubbleDialogDelegateView, which extends DialogDelegateView

ui/views/window/dialog_delegate.h

Index: ui/views/window/dialog_delegate.h
diff --git a/ui/views/window/dialog_delegate.h b/ui/views/window/dialog_delegate.h
index 68b1f202e2f95118126092ee4f0ff935faec4f47..f40a95dd85bf7832fb141fc6be3dcf01d4ceaf35 100644
--- a/ui/views/window/dialog_delegate.h
+++ b/ui/views/window/dialog_delegate.h
@@ -63,7 +63,7 @@ class VIEWS_EXPORT DialogDelegate : public ui::DialogModel,
 
   // Override this function to display a footnote view below the buttons.
   // Overrides may construct the view; this will only be called once per dialog.
-  virtual View* CreateFootnoteView();
+  virtual scoped_ptr<View> CreateFootnoteView();

[sky, 2016/02/23 17:56:16]

The return value of this is fed into BubbleFrameView::SetFootnoteView, which
takes a scoped_ptr as well. Problem with both of these is that they don't really
take ownership, instead they add the view to a parent view. If the view has been
configured with set_owned_by_client(), then the view is not deleted. scoped_ptr
implies ownership, not ownership somes times.

Views have their own ownership policy that in some ways conflicts with
scoped_ptr. I don't think we should be using scoped_ptr here or in
BubbleFrameView.

[Evan Stade, 2016/02/23 19:02:36]

ok, changed to bare pointer.

 
   // For Dialog boxes, if there is a "Cancel" button or no dialog button at all,
   // this is called when the user presses the "Cancel" button or the Esc key.