Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 1717453003: Introduce BubbleDialogDelegateView, which extends DialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/simple_message_box_views.cc
diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc
index 3f3973cb4d46e51d32b590fdd1c1f98853fc8245..6a02173defa0c2b64adf6d7253dabf4a639ebf8f 100644
--- a/chrome/browser/ui/views/simple_message_box_views.cc
+++ b/chrome/browser/ui/views/simple_message_box_views.cc
@@ -250,12 +250,18 @@ MessageBoxResult ShowMessageBoxImpl(gfx::NativeWindow parent,
} // namespace
-MessageBoxResult ShowMessageBox(gfx::NativeWindow parent,
msw 2016/02/22 21:43:56 Did you intend to change this file? If so, how is
Evan Stade 2016/02/22 22:58:22 nope, sorry, this is tangential. I broke it off in
- const base::string16& title,
- const base::string16& message,
- MessageBoxType type) {
- return ShowMessageBoxImpl(
- parent, title, message, type, base::string16(), base::string16());
+void ShowWarningMessageBox(gfx::NativeWindow parent,
+ const base::string16& title,
+ const base::string16& message) {
+ ShowMessageBoxImpl(parent, title, message, MESSAGE_BOX_TYPE_WARNING,
+ base::string16(), base::string16());
+}
+
+MessageBoxResult ShowQuestionMessageBox(gfx::NativeWindow parent,
+ const base::string16& title,
+ const base::string16& message) {
+ return ShowMessageBoxImpl(parent, title, message, MESSAGE_BOX_TYPE_QUESTION,
+ base::string16(), base::string16());
}
MessageBoxResult ShowMessageBoxWithButtonText(gfx::NativeWindow parent,

Powered by Google App Engine
This is Rietveld 408576698