Ignore title attribute for style elements in shadow trees.

Ignore title attribute for style elements in shadow trees.

Title attributes on style elements in shadow trees should not set the
preferred stylesheet name for the whole document. Also, title on style
elements in shadow trees should not respond to the preferred stylesheet
set in the top document.

BUG=588718
Committed: https://crrev.com/9c477d3b1df82392e5953d2bccfdf0ca371a6c07
Cr-Commit-Position: refs/heads/master@{#376776}

[rune, 2016-02-22 14:44:12]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 14:45:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717303002/1

[rune, 2016-02-22 14:46:52]

rune@opera.com changed reviewers:
+ dglazkov@chromium.org, hayato@chromium.org

[rune, 2016-02-22 14:46:52]

I've created an issue for the shadow dom spec, but it's not been included, so
feel free to shoot this down.

[dglazkov, 2016-02-22 16:44:45]

https://codereview.chromium.org/1717303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp (right):

https://codereview.chromium.org/1717303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp:97: if
(sheet->ownerNode() &&
sheet->ownerNode()->treeScope().rootNode().isShadowRoot())
would ownerNode()->isInShadowTree() not work?

[rune, 2016-02-22 17:38:16]

https://codereview.chromium.org/1717303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp (right):

https://codereview.chromium.org/1717303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp:97: if
(sheet->ownerNode() &&
sheet->ownerNode()->treeScope().rootNode().isShadowRoot())
On 2016/02/22 16:44:45, dglazkov wrote:
> would ownerNode()->isInShadowTree() not work?

Done.

[dglazkov, 2016-02-22 17:56:41]

lgtm

[rune, 2016-02-22 18:00:14]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-02-22 18:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717303002/20001

[commit-bot: I haz the power, 2016-02-22 19:37:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-22 19:38:43]

Description was changed from

==========
Ignore title attribute for style elements in shadow trees.

Title attributes on style elements in shadow trees should not set the
preferred stylesheet name for the whole document. Also, title on style
elements in shadow trees should not respond to the preferred stylesheet
set in the top document.

BUG=588718
==========

to

==========
Ignore title attribute for style elements in shadow trees.

Title attributes on style elements in shadow trees should not set the
preferred stylesheet name for the whole document. Also, title on style
elements in shadow trees should not respond to the preferred stylesheet
set in the top document.

BUG=588718

Committed: https://crrev.com/9c477d3b1df82392e5953d2bccfdf0ca371a6c07
Cr-Commit-Position: refs/heads/master@{#376776}
==========

[commit-bot: I haz the power, 2016-02-22 19:38:44]

Patchset 2 (id:??) landed as
https://crrev.com/9c477d3b1df82392e5953d2bccfdf0ca371a6c07
Cr-Commit-Position: refs/heads/master@{#376776}