third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp - Issue 1717303002: Ignore title attribute for style elements in shadow trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp

Issue 1717303002: Ignore title attribute for style elements in shadow trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use isInShadowTree Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets-expected.txt ('k') | third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp

diff --git a/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp b/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp

index a354052915f05fb745fbbe87ea23e658cdde1edb..c1ca1ac43f8731ced1baa91bd0cc81def73ec286 100644

--- a/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp

+++ b/third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp

@@ -57,14 +57,8 @@ void ShadowTreeStyleSheetCollection::collectStyleSheets(StyleEngine& engine, Sty

if (!sheet)

continue;

- // FIXME: clarify how PREFERRED or ALTERNATE works in shadow trees.

- // Should we set preferred/selected stylesheets name in shadow trees and

- // use the name in document?

- if (candidate.hasPreferrableName(engine.preferredStylesheetSetName()))

- engine.selectStylesheetSetName(candidate.title());

collection.appendSheetForList(sheet);

- if (candidate.canBeActivated(engine.preferredStylesheetSetName()))

+ if (candidate.canBeActivated(nullAtom))

collection.appendActiveStyleSheet(toCSSStyleSheet(sheet));

}