base/trace_event/heap_profiler_stack_frame_deduplicator.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/heap_profiler_stack_frame_deduplicator.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/heap_profiler_heap_dump_writer_unittest.cc ('k') | base/trace_event/heap_profiler_stack_frame_deduplicator.cc » ('j') | cc/layers/layer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/heap_profiler_stack_frame_deduplicator.h

diff --git a/base/trace_event/heap_profiler_stack_frame_deduplicator.h b/base/trace_event/heap_profiler_stack_frame_deduplicator.h

index e8c693a990c10c595fd5ff9cd48b6cebbfedc137..4932534e1d790a578290effd9590bc0fe43a64bb 100644

--- a/base/trace_event/heap_profiler_stack_frame_deduplicator.h

+++ b/base/trace_event/heap_profiler_stack_frame_deduplicator.h

@@ -47,6 +47,7 @@ class BASE_EXPORT StackFrameDeduplicator : public ConvertableToTraceFormat {

using ConstIterator = std::vector<FrameNode>::const_iterator;

StackFrameDeduplicator();

+ ~StackFrameDeduplicator() override;

// Inserts a backtrace where |beginFrame| is a pointer to the bottom frame

// (e.g. main) and |endFrame| is a pointer past the top frame (most recently

@@ -66,8 +67,6 @@ class BASE_EXPORT StackFrameDeduplicator : public ConvertableToTraceFormat {

void EstimateTraceMemoryOverhead(TraceEventMemoryOverhead* overhead) override;

private:

- ~StackFrameDeduplicator() override;

std::map<StackFrame, int> roots_;

std::vector<FrameNode> frames_;