base/trace_event/heap_profiler_stack_frame_deduplicator.cc - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/heap_profiler_stack_frame_deduplicator.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/heap_profiler_stack_frame_deduplicator.h ('k') | base/trace_event/heap_profiler_stack_frame_deduplicator_unittest.cc » ('j') | cc/layers/layer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/heap_profiler_stack_frame_deduplicator.cc

diff --git a/base/trace_event/heap_profiler_stack_frame_deduplicator.cc b/base/trace_event/heap_profiler_stack_frame_deduplicator.cc

index 5e11e9d7af620e9cce05ed62a2e9a3926f6a0d7d..95685250cd23a9dd42e61ebc43e41cfb622f244d 100644

--- a/base/trace_event/heap_profiler_stack_frame_deduplicator.cc

+++ b/base/trace_event/heap_profiler_stack_frame_deduplicator.cc

@@ -77,7 +77,7 @@ void StackFrameDeduplicator::AppendAsTraceFormat(std::string* out) const {

SStringPrintf(&stringify_buffer, "\"%d\":", i);

out->append(stringify_buffer);

- scoped_refptr<TracedValue> frame_node_value = new TracedValue;

+ scoped_ptr<TracedValue> frame_node_value(new TracedValue);

frame_node_value->SetString("name", frame_node->frame);

if (frame_node->parent_frame_index >= 0) {

SStringPrintf(&stringify_buffer, "%d", frame_node->parent_frame_index);