cc/layers/layer.cc - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer.cc

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No need for refptr, active layer outlives pending, whatever it means Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer.cc

diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc

index 5a7796c829869f6d373ba23274435bfb4b675c9c..b4fec7ae47a7bbe528a480d25c246475f2343ec6 100644

--- a/cc/layers/layer.cc

+++ b/cc/layers/layer.cc

@@ -1750,8 +1750,7 @@ bool Layer::IsSuitableForGpuRasterization() const {

return true;

}

-scoped_refptr<base::trace_event::ConvertableToTraceFormat>

-Layer::TakeDebugInfo() {

+scoped_ptr<base::trace_event::ConvertableToTraceFormat> Layer::TakeDebugInfo() {

if (client_)

return client_->TakeDebugInfo(this);

else

« no previous file with comments | « cc/layers/layer.h ('k') | cc/layers/layer_client.h » ('j') | cc/layers/layer_impl.cc » ('J')