cc/layers/layer.h - Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer.h

Issue 1717283003: tracing: Make ConvertableToTraceFormat move-only scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No need for refptr, active layer outlives pending, whatever it means Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer.h

diff --git a/cc/layers/layer.h b/cc/layers/layer.h

index afb5356238325f395b8b66912c34e740c75972e7..c0a8c46f30d09eb8f666f687c39b99f75ee109e3 100644

--- a/cc/layers/layer.h

+++ b/cc/layers/layer.h

@@ -364,7 +364,7 @@ class CC_EXPORT Layer : public base::RefCounted<Layer>,

virtual void SetIsMask(bool is_mask) {}

virtual bool IsSuitableForGpuRasterization() const;

- virtual scoped_refptr<base::trace_event::ConvertableToTraceFormat>

+ virtual scoped_ptr<base::trace_event::ConvertableToTraceFormat>

TakeDebugInfo();

void SetLayerClient(LayerClient* client) { client_ = client; }

« no previous file with comments | « cc/debug/traced_display_item_list.cc ('k') | cc/layers/layer.cc » ('j') | cc/layers/layer_impl.cc » ('J')