cleanup to InvocationExpression AST declaration

cleanup to InvocationExpression AST declaration

follow up to https://github.com/dart-lang/sdk/commit/0c4e64c8efafd9ac6d8fd004706ee69639b0d04f
splits getter/setter, fixes some sorting

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/18ef4ba22be0d37b89a25f82f579b1527fdd7053

[Jennifer Messerly, 2016-02-22 23:11:01]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-23 00:11:08]

LGTM

https://codereview.chromium.org/1717243003/diff/1/pkg/analyzer/lib/dart/ast/a...
File pkg/analyzer/lib/dart/ast/ast.dart (right):

https://codereview.chromium.org/1717243003/diff/1/pkg/analyzer/lib/dart/ast/a...
pkg/analyzer/lib/dart/ast/ast.dart:5010: void set propagatedInvokeType(DartType
value);
Do we need the setters on the interface, or can we put them on the Impl class?
I'd prefer the latter if possible.

[Jennifer Messerly, 2016-02-23 00:49:53]

thanks!

https://codereview.chromium.org/1717243003/diff/1/pkg/analyzer/lib/dart/ast/a...
File pkg/analyzer/lib/dart/ast/ast.dart (right):

https://codereview.chromium.org/1717243003/diff/1/pkg/analyzer/lib/dart/ast/a...
pkg/analyzer/lib/dart/ast/ast.dart:5010: void set propagatedInvokeType(DartType
value);
On 2016/02/23 00:11:08, Brian Wilkerson wrote:
> Do we need the setters on the interface, or can we put them on the Impl class?
> I'd prefer the latter if possible.

Currently, yes. Otherwise, the only way to set it would involve an unsafe
downcast.

[Jennifer Messerly, 2016-02-23 00:52:55]

Description was changed from

==========
cleanup to InvocationExpression AST declaration

follow up to
https://github.com/dart-lang/sdk/commit/0c4e64c8efafd9ac6d8fd004706ee69639b0d04f
splits getter/setter, fixes some sorting
==========

to

==========
cleanup to InvocationExpression AST declaration

follow up to
https://github.com/dart-lang/sdk/commit/0c4e64c8efafd9ac6d8fd004706ee69639b0d04f
splits getter/setter, fixes some sorting

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/18ef4ba22be0d37b89a25f82f579b1527fdd7053
==========

[Jennifer Messerly, 2016-02-23 00:52:56]

Committed patchset #1 (id:1) manually as
18ef4ba22be0d37b89a25f82f579b1527fdd7053 (presubmit successful).