cleanup to InvocationExpression AST declaration

pkg/analyzer/lib/dart/ast/ast.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Defines the AST model. The AST (Abstract Syntax Tree) model describes the
  * syntactic (as opposed to semantic) structure of Dart code. The semantic
  * structure of the code is modeled by the
  * [element model](../element/element.dart).
  *
@@ skipping 4956 matching lines @@
 }
 
 /**
  * The invocation of a function or method; either a
  * [FunctionExpressionInvocation] or a [MethodInvocation].
  *
  * Clients may not extend, implement or mix-in this class.
  */
 abstract class InvocationExpression extends Expression {
   /**
+   * Return the list of arguments to the method.
+   */
+  ArgumentList get argumentList;
+
+  /**
+   * The expression that identifies the function or method being invoked.
+   * For example:
+   *
+   *     (o.m)<TArgs>(args); // target will be `o.m`
+   *     o.m<TArgs>(args);   // target will be `m`
+   *
+   * In either case, the [function.staticType] will be the
+   * [staticInvokeType] before applying type arguments `TArgs`. Similarly,
+   * [function.propagatedType] will be the [propagatedInvokeType]
+   * before applying type arguments `TArgs`.
+   */
+  Expression get function;
+
+  /**
    * Return the function type of the invocation based on the propagated type
    * information, or `null` if the AST structure has not been resolved, or if
    * the invoke could not be resolved.
    *
    * This will usually be a [FunctionType], but it can also be an
    * [InterfaceType] with a `call` method, `dynamic`, `Function`, or a `@proxy`
    * interface type that implements `Function`.
    */
-  DartType propagatedInvokeType;
+  DartType get propagatedInvokeType;
+
+  /**
+   * Sets the function type of the invocation based on the propagated type
+   * information.
+   */
+  void set propagatedInvokeType(DartType value);

[Brian Wilkerson, 2016/02/23 00:11:08]

Do we need the setters on the interface, or can we put them on the Impl class?
I'd prefer the latter if possible.

[Jennifer Messerly, 2016/02/23 00:49:52]

Currently, yes. Otherwise, the only way to set it would involve an unsafe
downcast.

 
   /**
    * Return the function type of the invocation based on the static type
    * information, or `null` if the AST structure has not been resolved, or if
    * the invoke could not be resolved.
    *
    * This will usually be a [FunctionType], but it can also be an
    * [InterfaceType] with a `call` method, `dynamic`, `Function`, or a `@proxy`
    * interface type that implements `Function`.
    */
-  DartType staticInvokeType;
+  DartType get staticInvokeType;
 
   /**
-   * Return the list of arguments to the method.
+   * Sets the function type of the invocation based on the static type
+   * information.
    */
-  ArgumentList get argumentList;
-
-  /**
-   * The expression that identifies the function or method being invoked.
-   * For example:
-   *
-   *     (o.m)<TArgs>(args); // target will be `o.m`
-   *     o.m<TArgs>(args);   // target will be `m`
-   *
-   * In either case, the [function.staticType] will be the
-   * [staticInvokeType] before applying type arguments `TArgs`. Similarly,
-   * [function.propagatedType] will be the [propagatedInvokeType]
-   * before applying type arguments `TArgs`.
-   */
-  Expression get function;
+  void set staticInvokeType(DartType value);
 
   /**
    * Return the type arguments to be applied to the method being invoked, or
    * `null` if no type arguments were provided.
    */
   TypeArgumentList get typeArguments;
 }
 
 /**
  * An is expression.
@@ skipping 3043 matching lines @@
   /**
    * Return the 'yield' keyword.
    */
   Token get yieldKeyword;
 
   /**
    * Return the 'yield' keyword to the given [token].
    */
   void set yieldKeyword(Token token);
 }