Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1717213002: Allow negative literals in asm->wasm non-conversion operations. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow negative literals in asm->wasm non-conversion operations. This allows expressions like: (x + y) & -1 [intish] & [signed] The previous conversion condition was too strict (intended to forbid non-int expression conversion). Expressing in a different way. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/c8c5b3fddf2c8ee5df5854359b71a345f5ece3ba Cr-Commit-Position: refs/heads/master@{#34228}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/typing-asm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
bradnelson
4 years, 10 months ago (2016-02-22 02:54:17 UTC) #2
aseemgarg
There is also an issue of negative doubles not getting through. Maybe fix that as ...
4 years, 10 months ago (2016-02-22 21:58:39 UTC) #3
bradnelson
So I think parsing of negative doubles got fixed at some point, however, the issue ...
4 years, 10 months ago (2016-02-23 07:49:37 UTC) #4
aseemgarg
lgtm
4 years, 10 months ago (2016-02-23 19:19:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717213002/20001
4 years, 10 months ago (2016-02-23 19:37:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11394)
4 years, 10 months ago (2016-02-23 19:39:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717213002/40001
4 years, 10 months ago (2016-02-23 20:42:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 21:09:51 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 21:10:27 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c8c5b3fddf2c8ee5df5854359b71a345f5ece3ba
Cr-Commit-Position: refs/heads/master@{#34228}

Powered by Google App Engine
This is Rietveld 408576698