Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: src/typing-asm.cc

Issue 1717213002: Allow negative literals in asm->wasm non-conversion operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: merge Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/asm-wasm.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing-asm.cc
diff --git a/src/typing-asm.cc b/src/typing-asm.cc
index b74816f9011292b099262bebc81faa02a87b5f8f..1160273fe260499c408335e9866add949344178b 100644
--- a/src/typing-asm.cc
+++ b/src/typing-asm.cc
@@ -1113,7 +1113,7 @@ void AsmTyper::VisitIntegerBitwiseOperator(BinaryOperation* expr,
right_type = left_type;
}
if (!conversion) {
- if (!left_type->Is(right_type) || !right_type->Is(left_type)) {
+ if (!left_type->Is(cache_.kAsmInt) || !right_type->Is(cache_.kAsmInt)) {
FAIL(expr, "ill-typed bitwise operation");
}
}
« no previous file with comments | « no previous file | test/mjsunit/wasm/asm-wasm.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698