Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: google_apis/gcm/engine/mcs_client.h

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/mcs_client.h
diff --git a/google_apis/gcm/engine/mcs_client.h b/google_apis/gcm/engine/mcs_client.h
index 70f4f2ec93dfcd99271a2f43df75e5726578f4c6..e0f8fdbc29e66555b080fd4193b50aecddcb4981 100644
--- a/google_apis/gcm/engine/mcs_client.h
+++ b/google_apis/gcm/engine/mcs_client.h
@@ -83,7 +83,8 @@ class GCM_EXPORT MCSClient {
const std::string& message_id,
MessageSendStatus status)> OnMessageSentCallback;
- MCSClient(base::Clock* clock,
+ MCSClient(const std::string& version_string,
+ base::Clock* clock,
ConnectionFactory* connection_factory,
GCMStore* gcm_store);
virtual ~MCSClient();
@@ -193,6 +194,9 @@ class GCM_EXPORT MCSClient {
void NotifyMessageSendStatus(const google::protobuf::MessageLite& protobuf,
MessageSendStatus status);
+ // Local version string. Sent on login.
+ const std::string version_string_;
+
// Clock for enforcing TTL. Passed in for testing.
base::Clock* const clock_;

Powered by Google App Engine
This is Rietveld 408576698