Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: google_apis/gcm/engine/connection_handler_impl_unittest.cc

Issue 171683002: [GCM] Fix gcm login to properly identify chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/connection_handler_impl_unittest.cc
diff --git a/google_apis/gcm/engine/connection_handler_impl_unittest.cc b/google_apis/gcm/engine/connection_handler_impl_unittest.cc
index d9f381ba2ac23fc91ba948038a0057837852ed90..b0e7c6a11fbb50c744829cc2a8acb759033296a7 100644
--- a/google_apis/gcm/engine/connection_handler_impl_unittest.cc
+++ b/google_apis/gcm/engine/connection_handler_impl_unittest.cc
@@ -27,7 +27,7 @@ typedef std::vector<net::MockWrite> WriteList;
const uint64 kAuthId = 54321;
const uint64 kAuthToken = 12345;
-const char kMCSVersion = 38; // The protocol version.
+const char kMCSVersion = 41; // The protocol version.
const int kMCSPort = 5228; // The server port.
const char kDataMsgFrom[] = "data_from";
const char kDataMsgCategory[] = "data_category";
@@ -69,7 +69,7 @@ std::string EncodeHandshakeRequest() {
result.append(version_byte, 1);
std::vector<int64> user_serial_numbers;
ScopedMessage login_request(
- BuildLoginRequest(kAuthId, kAuthToken, user_serial_numbers));
+ BuildLoginRequest(kAuthId, kAuthToken, "", user_serial_numbers));
result.append(EncodePacket(kLoginRequestTag,
login_request->SerializeAsString()));
return result;
@@ -206,7 +206,7 @@ void GCMConnectionHandlerImplTest::Connect(
EXPECT_FALSE(connection_handler()->CanSendMessage());
std::vector<int64> user_serial_numbers;
connection_handler_->Init(
- *BuildLoginRequest(kAuthId, kAuthToken, user_serial_numbers),
+ *BuildLoginRequest(kAuthId, kAuthToken, "", user_serial_numbers),
socket_.get());
}

Powered by Google App Engine
This is Rietveld 408576698