chrome/android/java/res/layout/custom_tabs_bottombar.xml - Issue 1716683002: [Custom Tabs] Allow clients to display RemoteViews on the bottom bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_bottombar.xml

Issue 1716683002: [Custom Tabs] Allow clients to display RemoteViews on the bottom bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/res/layout/custom_tabs_bottombar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_bottombar.xml b/chrome/android/java/res/layout/custom_tabs_bottombar.xml

index 3651d62436d744729b7c52b3bec1020199f7e78d..217263ba624b5328f5ed714f5360289145df66e0 100644

--- a/chrome/android/java/res/layout/custom_tabs_bottombar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_bottombar.xml

@@ -2,9 +2,11 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

+<org.chromium.chrome.browser.widget.BoundedLinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

+ xmlns:chrome="http://schemas.android.com/apk/res-auto"

android:id="@+id/bottombar"

android:layout_width="match_parent"

- android:layout_height="@dimen/toolbar_height_no_shadow"

+ android:layout_height="wrap_content"

+ chrome:maxHeight="@dimen/toolbar_height_no_shadow"

newt (away) 2016/02/19 03:18:51 nit: put chrome:maxHeight after all the android at

Ian Wen 2016/02/26 18:32:52 Done.

android:orientation="horizontal" >

-</LinearLayout>

+</org.chromium.chrome.browser.widget.BoundedLinearLayout>

newt (away) 2016/02/19 03:18:51 If you want, you can remove this line and change t

Ian Wen 2016/02/26 18:32:52 Done.

« no previous file with comments | « no previous file | chrome/android/java/res/values/attrs.xml » ('j') | no next file with comments »