chrome/android/java/res/layout/custom_tabs_bottombar.xml - Issue 1716683002: [Custom Tabs] Allow clients to display RemoteViews on the bottom bar

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/custom_tabs_bottombar.xml

Issue 1716683002: [Custom Tabs] Allow clients to display RemoteViews on the bottom bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	5 <org.chromium.chrome.browser.widget.BoundedLinearLayout xmlns:android="http://sc hemas.android.com/apk/res/android"

	6 xmlns:chrome="http://schemas.android.com/apk/res-auto"

6 android:id="@+id/bottombar"	7 android:id="@+id/bottombar"

7 android:layout_width="match_parent"	8 android:layout_width="match_parent"

8 android:layout_height="@dimen/toolbar_height_no_shadow"	9 android:layout_height="wrap_content"

	10 chrome:maxHeight="@dimen/toolbar_height_no_shadow"
	newt (away) 2016/02/19 03:18:51 nit: put chrome:maxHeight after all the android at nit: put chrome:maxHeight after all the android attributes Ian Wen 2016/02/26 18:32:52 Done. Show quoted text On 2016/02/19 03:18:51, newt wrote: > nit: put chrome:maxHeight after all the android attributes Done.
9 android:orientation="horizontal" >	11 android:orientation="horizontal" >

10 </LinearLayout>	12 </org.chromium.chrome.browser.widget.BoundedLinearLayout>
	newt (away) 2016/02/19 03:18:51 If you want, you can remove this line and change t If you want, you can remove this line and change the line above from ">" to "/>" Ian Wen 2016/02/26 18:32:52 Done. Show quoted text On 2016/02/19 03:18:51, newt wrote: > If you want, you can remove this line and change the line above from ">" to "/>" Done.
OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/values/attrs.xml » ('j') | no next file with comments »