[Custom Tabs] Allow clients to display RemoteViews on the bottom bar

[Custom Tabs] Allow clients to display RemoteViews on the bottom bar

RemoteViews is an android widget that allows the client app to configure
a fully customized view. After this patch, Chrome will display the
remote views as long as the clients send the view through intent extra.

BUG=TBD

Committed: https://crrev.com/3902d6fa223f7ed51fbd38f5ab1ce2a492e148e1
Cr-Commit-Position: refs/heads/master@{#378086}

[Ian Wen, 2016-02-19 02:17:39]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org, yusufo@chromium.org

[Ian Wen, 2016-02-19 02:17:40]

yusufo@ PTAL everything.
newt@ PTAL the change in widget folder.

Thanks!

[newt (away), 2016-02-19 03:18:51]

resources and BoundedLinearLayout lgtm modulo nits. Nice work :)

https://codereview.chromium.org/1716683002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/custom_tabs_bottombar.xml (right):

https://codereview.chromium.org/1716683002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/custom_tabs_bottombar.xml:10:
chrome:maxHeight="@dimen/toolbar_height_no_shadow"
nit: put chrome:maxHeight after all the android attributes

https://codereview.chromium.org/1716683002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/custom_tabs_bottombar.xml:12:
</org.chromium.chrome.browser.widget.BoundedLinearLayout>
If you want, you can remove this line and change the line above from ">" to "/>"

[Yusuf, 2016-02-26 18:03:07]

lgtm

Sorry got the delay Ian!

[Ian Wen, 2016-02-26 18:32:52]

All addressed. Thanks for reviewing.

https://codereview.chromium.org/1716683002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/custom_tabs_bottombar.xml (right):

https://codereview.chromium.org/1716683002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/custom_tabs_bottombar.xml:10:
chrome:maxHeight="@dimen/toolbar_height_no_shadow"
On 2016/02/19 03:18:51, newt wrote:
> nit: put chrome:maxHeight after all the android attributes

Done.

https://codereview.chromium.org/1716683002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/custom_tabs_bottombar.xml:12:
</org.chromium.chrome.browser.widget.BoundedLinearLayout>
On 2016/02/19 03:18:51, newt wrote:
> If you want, you can remove this line and change the line above from ">" to
"/>"

Done.

[Ian Wen, 2016-02-26 18:32:56]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-02-26 18:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1716683002/#ps40001
(title: "lint xmls")

[commit-bot: I haz the power, 2016-02-26 18:35:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716683002/40001

[commit-bot: I haz the power, 2016-02-26 19:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 19:32:06]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Ian Wen, 2016-02-27 00:57:18]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-02-27 00:57:18]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1716683002/#ps60001
(title: "make findbug happy")

[commit-bot: I haz the power, 2016-02-27 01:03:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1716683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1716683002/60001

[commit-bot: I haz the power, 2016-02-27 02:28:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-27 02:29:36]

Description was changed from

==========
[Custom Tabs] Allow clients to display RemoteViews on the bottom bar

RemoteViews is an android widget that allows the client app to configure
a fully customized view. After this patch, Chrome will display the
remote views as long as the clients send the view through intent extra.

BUG=TBD
==========

to

==========
[Custom Tabs] Allow clients to display RemoteViews on the bottom bar

RemoteViews is an android widget that allows the client app to configure
a fully customized view. After this patch, Chrome will display the
remote views as long as the clients send the view through intent extra.

BUG=TBD

Committed: https://crrev.com/3902d6fa223f7ed51fbd38f5ab1ce2a492e148e1
Cr-Commit-Position: refs/heads/master@{#378086}
==========

[commit-bot: I haz the power, 2016-02-27 02:29:37]

Patchset 4 (id:??) landed as
https://crrev.com/3902d6fa223f7ed51fbd38f5ab1ce2a492e148e1
Cr-Commit-Position: refs/heads/master@{#378086}