More shared messages.

More shared messages.

R=brianwilkerson@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/7db06aedc448486d5eeb2b4163371de0dcc3f6d9

[floitsch, 2016-02-18 20:43:29]

floitsch@google.com changed reviewers:
+ brianwilkerson@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2016-02-18 21:04:13]

lgtm, with comments below

https://codereview.chromium.org/1716463002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1716463002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3661: if (!inCatchBlock &&
node.throwToken.stringValue == 'rethrow') {
I believe we don't need the extra check (I thought the Rethrow node is only
created when the token is a rethrow token)

https://codereview.chromium.org/1716463002/diff/1/pkg/dart_messages/lib/share...
File pkg/dart_messages/lib/shared_messages.dart (right):

https://codereview.chromium.org/1716463002/diff/1/pkg/dart_messages/lib/share...
pkg/dart_messages/lib/shared_messages.dart:411: template: "Throw expressions
must compute the object to be thrown.",
nit: in this case I prefer the old message we used to have in dart2js, I somehow
find the "compute" here a bit misleading.

Some ideas:
- No expression after 'throw'.
- Throw missing the subexpression to be thrown.
- Throw expression missing an argument to be thrown.

[Brian Wilkerson, 2016-02-18 21:06:01]

LGTM, but it duplicates the changes in another CL.

[floitsch, 2016-02-18 21:12:18]

@Brian: it doesn't duplicate the work. The other CL is a follow-up CL to this
one. This is, why it has already some of the new messages.

https://codereview.chromium.org/1716463002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1716463002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3661: if (!inCatchBlock &&
node.throwToken.stringValue == 'rethrow') {
On 2016/02/18 21:04:13, Siggi Cherem (dart-lang) wrote:
> I believe we don't need the extra check (I thought the Rethrow node is only
> created when the token is a rethrow token)

Unfortunately it's required. A simple 'throw' is still creating a 'Rethrow'
node.

Eventually that should get fixed, but this is the faster/simpler fix.

https://codereview.chromium.org/1716463002/diff/1/pkg/dart_messages/lib/share...
File pkg/dart_messages/lib/shared_messages.dart (right):

https://codereview.chromium.org/1716463002/diff/1/pkg/dart_messages/lib/share...
pkg/dart_messages/lib/shared_messages.dart:411: template: "Throw expressions
must compute the object to be thrown.",
On 2016/02/18 21:04:13, Siggi Cherem (dart-lang) wrote:
> nit: in this case I prefer the old message we used to have in dart2js, I
somehow
> find the "compute" here a bit misleading.
> 
> Some ideas:
> - No expression after 'throw'.
> - Throw missing the subexpression to be thrown.
> - Throw expression missing an argument to be thrown.

Going with "Missing expression after 'throw'."
Perfectly happy to change to something else (in a follow up CL).

[floitsch, 2016-02-18 21:13:19]

Description was changed from

==========
More shared messages.
==========

to

==========
More shared messages.

R=brianwilkerson@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7db06aedc448486d5eeb2b4163371de0dcc3f6d9
==========

[floitsch, 2016-02-18 21:13:21]

Committed patchset #2 (id:20001) manually as
7db06aedc448486d5eeb2b4163371de0dcc3f6d9 (presubmit successful).