Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1716463002: More shared messages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 1aa2d17ebba2e53bce1bfa0248507f6d225fbb42..d2e2f6e35b5e6d7c288f7d2ebf6f4557a3bd046e 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -3658,9 +3658,9 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
}
ResolutionResult visitRethrow(Rethrow node) {
- if (!inCatchBlock) {
+ if (!inCatchBlock && node.throwToken.stringValue == 'rethrow') {
reporter.reportErrorMessage(
- node, MessageKind.THROW_WITHOUT_EXPRESSION);
+ node, MessageKind.RETHROW_OUTSIDE_CATCH);
}
return const NoneResult();
}
« no previous file with comments | « pkg/compiler/lib/src/parser/node_listener.dart ('k') | pkg/dart_messages/lib/generated/shared_messages.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698