Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp

Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp
index e6ed820d357e969f1128b9e2336ba6041844818e..ae54ed6a7f8afcf4378865bd156f63726cb403a5 100644
--- a/third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp
@@ -170,11 +170,10 @@ TEST(SecurityPolicyTest, TrustworthyWhiteList)
};
for (const char* url : insecureURLs) {
- String errorMessage;
RefPtr<SecurityOrigin> origin = SecurityOrigin::createFromString(url);
- EXPECT_FALSE(origin->isPotentiallyTrustworthy(errorMessage));
+ EXPECT_FALSE(origin->isPotentiallyTrustworthy());
SecurityPolicy::addOriginTrustworthyWhiteList(origin);
- EXPECT_TRUE(origin->isPotentiallyTrustworthy(errorMessage));
+ EXPECT_TRUE(origin->isPotentiallyTrustworthy());
}
// Tests that adding URLs that have inner-urls to the whitelist
@@ -199,17 +198,15 @@ TEST(SecurityPolicyTest, TrustworthyWhiteList)
},
};
for (const TestCase& test : insecureURLsWithInnerOrigin) {
- String errorMessage;
-
// Actually origins of both URLs should be same.
RefPtr<SecurityOrigin> origin1 = SecurityOrigin::createFromString(test.url);
RefPtr<SecurityOrigin> origin2 = SecurityOrigin::createFromString(test.anotherUrlInOrigin);
- EXPECT_FALSE(origin1->isPotentiallyTrustworthy(errorMessage));
- EXPECT_FALSE(origin2->isPotentiallyTrustworthy(errorMessage));
+ EXPECT_FALSE(origin1->isPotentiallyTrustworthy());
+ EXPECT_FALSE(origin2->isPotentiallyTrustworthy());
SecurityPolicy::addOriginTrustworthyWhiteList(origin1);
- EXPECT_TRUE(origin1->isPotentiallyTrustworthy(errorMessage));
- EXPECT_TRUE(origin2->isPotentiallyTrustworthy(errorMessage));
+ EXPECT_TRUE(origin1->isPotentiallyTrustworthy());
+ EXPECT_TRUE(origin2->isPotentiallyTrustworthy());
}
}
« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698