third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp - Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

Issue 1716303002: Remove SecurityOrigin::isPotentiallyTrustworthy() |errorMessage| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp ('k') | third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

index 3c46272be5889f671cd239fd924f7297fda0f49c..c04fd588b23c3ad4a3ebd75a33e80dac9768bbd8 100644

--- a/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

@@ -157,15 +157,12 @@ TEST_F(SecurityOriginTest, IsPotentiallyTrustworthy)

SCOPED_TRACE(i);

RefPtr<SecurityOrigin> origin = SecurityOrigin::createFromString(inputs[i].url);

String errorMessage;

- EXPECT_EQ(inputs[i].accessGranted, origin->isPotentiallyTrustworthy(errorMessage));

- EXPECT_EQ(inputs[i].accessGranted, errorMessage.isEmpty());

+ EXPECT_EQ(inputs[i].accessGranted, origin->isPotentiallyTrustworthy());

}

// Unique origins are not considered secure.

RefPtr<SecurityOrigin> uniqueOrigin = SecurityOrigin::createUnique();

- String errorMessage;

- EXPECT_FALSE(uniqueOrigin->isPotentiallyTrustworthy(errorMessage));

- EXPECT_EQ("Only secure origins are allowed (see: https://goo.gl/Y0ZkNV).", errorMessage);

+ EXPECT_FALSE(uniqueOrigin->isPotentiallyTrustworthy());

}

TEST_F(SecurityOriginTest, IsSecure)