Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1716243002: [wasm] Added I64Ior to the Int64Lowering. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int64-lowering-unittest
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Added I64Ior to the Int64Lowering. R=titzer@chromium.org Committed: https://crrev.com/cadc1e7780e2fe69f1ee98a0305f19df30c08549 Cr-Commit-Position: refs/heads/master@{#34219}

Patch Set 1 #

Patch Set 2 : Added the merge TODO list also to the wasm-compiler. #

Patch Set 3 : I created the new test file test-run-wasm-64.cc #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -94 lines) Patch
M src/compiler/int64-lowering.cc View 2 chunks +79 lines, -21 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 chunks +48 lines, -3 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 4 chunks +0 lines, -70 lines 0 comments Download
A test/cctest/wasm/test-run-wasm-64.cc View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ahaas
4 years, 10 months ago (2016-02-22 16:04:06 UTC) #1
titzer
lgtm
4 years, 10 months ago (2016-02-23 00:43:03 UTC) #2
ahaas
On 2016/02/23 at 00:43:03, titzer wrote: > lgtm PTAL: As suggested in https://codereview.chromium.org/1723613002, I created ...
4 years, 10 months ago (2016-02-23 10:46:43 UTC) #3
titzer
On 2016/02/23 10:46:43, ahaas wrote: > On 2016/02/23 at 00:43:03, titzer wrote: > > lgtm ...
4 years, 10 months ago (2016-02-23 15:54:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716243002/60001
4 years, 10 months ago (2016-02-23 16:04:56 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-23 16:30:33 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 16:30:49 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cadc1e7780e2fe69f1ee98a0305f19df30c08549
Cr-Commit-Position: refs/heads/master@{#34219}

Powered by Google App Engine
This is Rietveld 408576698