Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1723613002: [wasm] Added I64Xor to the Int64Lowering. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int64-lowering-ior
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Added I64Xor to the Int64Lowering. R=titzer@chromium.org Committed: https://crrev.com/a8d5d176598c131bb16b0c9767facf7d768c2d68 Cr-Commit-Position: refs/heads/master@{#34241}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Patch Set 4 : removed merge marker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M src/compiler/int64-lowering.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ahaas
4 years, 10 months ago (2016-02-22 16:24:30 UTC) #1
titzer
lgtm
4 years, 10 months ago (2016-02-23 00:51:47 UTC) #2
titzer
https://codereview.chromium.org/1723613002/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1723613002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode2502 test/cctest/wasm/test-run-wasm.cc:2502: TEST(Run_WasmI64Xor) { This file is going to get big; ...
4 years, 10 months ago (2016-02-23 00:52:42 UTC) #3
ahaas
On 2016/02/23 at 00:52:42, titzer wrote: > https://codereview.chromium.org/1723613002/diff/1/test/cctest/wasm/test-run-wasm.cc > File test/cctest/wasm/test-run-wasm.cc (right): > > https://codereview.chromium.org/1723613002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode2502 ...
4 years, 10 months ago (2016-02-23 16:42:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723613002/40001
4 years, 10 months ago (2016-02-23 16:42:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/15752) v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 16:44:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723613002/60001
4 years, 10 months ago (2016-02-24 09:37:54 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-24 09:51:34 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 09:53:00 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a8d5d176598c131bb16b0c9767facf7d768c2d68
Cr-Commit-Position: refs/heads/master@{#34241}

Powered by Google App Engine
This is Rietveld 408576698