Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1716073002: Fix changes in the snap-height property to invalidate layout (Closed)

Created:
4 years, 10 months ago by kojii
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix changes in the snap-height property to invalidate layout This patch fixes changes in the snap-height property to invalidate layout properly. Changes in the snap-height property should have the same invalidation as the line-height property. The test was imported from csswg-test in crrev.com/376661. BUG=586413 TEST=imported/csswg-test/css-snap-size-1/snap-height-dynamic-001.html Committed: https://crrev.com/a41bdfe9824c54d2f6246a9a0ea074c696b8d5d1 Cr-Commit-Position: refs/heads/master@{#376673}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
D third_party/WebKit/LayoutTests/imported/csswg-test/css-snap-size-1/snap-height-dynamic-001-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kojii
PTAL.
4 years, 10 months ago (2016-02-21 09:59:07 UTC) #3
Timothy Loh
On 2016/02/21 09:59:07, kojii wrote: > PTAL. lgtm
4 years, 10 months ago (2016-02-21 23:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716073002/20001
4 years, 10 months ago (2016-02-22 00:20:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-22 00:24:43 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 00:26:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a41bdfe9824c54d2f6246a9a0ea074c696b8d5d1
Cr-Commit-Position: refs/heads/master@{#376673}

Powered by Google App Engine
This is Rietveld 408576698