third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 1716073002: Fix changes in the snap-height property to invalidate layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1716073002: Fix changes in the snap-height property to invalidate layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/csswg-test/css-snap-size-1/snap-height-dynamic-001-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 2b68b3597fccb9935f964bf39b36d51ec7e41a0a..42d731c520679077eddd28a2cc41662c8ef1fc8d 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -583,6 +583,8 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(const ComputedStyle&

|| rareInheritedData->m_textCombine != other.rareInheritedData->m_textCombine

|| rareInheritedData->m_tabSize != other.rareInheritedData->m_tabSize

|| rareInheritedData->listStyleImage != other.rareInheritedData->listStyleImage

+ || rareInheritedData->m_snapHeightUnit != other.rareInheritedData->m_snapHeightUnit

+ || rareInheritedData->m_snapHeightPosition != other.rareInheritedData->m_snapHeightPosition

|| rareInheritedData->textStrokeWidth != other.rareInheritedData->textStrokeWidth)

return true;

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/csswg-test/css-snap-size-1/snap-height-dynamic-001-expected.txt ('k') | no next file » | no next file with comments »