Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: net/url_request/url_request.cc

Issue 1716007: Cleanup: Address some of the todos in net_log.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket_stream/socket_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
===================================================================
--- net/url_request/url_request.cc (revision 45472)
+++ net/url_request/url_request.cc (working copy)
@@ -260,7 +260,7 @@
DCHECK(!job_);
net_log_.BeginEventWithString(net::NetLog::TYPE_URL_REQUEST_START,
- original_url().possibly_invalid_spec());
+ "url", original_url().possibly_invalid_spec());
job_ = job;
job_->SetExtraRequestHeaders(extra_request_headers_);
@@ -368,7 +368,7 @@
void URLRequest::ResponseStarted() {
if (!status_.is_success()) {
net_log_.EndEventWithInteger(net::NetLog::TYPE_URL_REQUEST_START,
- status_.os_error());
+ "net_error", status_.os_error());
} else {
net_log_.EndEvent(net::NetLog::TYPE_URL_REQUEST_START);
}
@@ -445,8 +445,8 @@
int URLRequest::Redirect(const GURL& location, int http_status_code) {
if (net_log_.HasListener()) {
- net_log_.AddString(StringPrintf("Redirected (%d) to %s",
- http_status_code, location.spec().c_str()));
+ net_log_.AddEventWithString(net::NetLog::TYPE_URL_REQUEST_REDIRECTED,
+ "location", location.possibly_invalid_spec());
}
if (redirect_limit_ <= 0) {
DLOG(INFO) << "disallowing redirect: exceeds limit";
« no previous file with comments | « net/socket_stream/socket_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698