Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: net/socket_stream/socket_stream.cc

Issue 1716007: Cleanup: Address some of the todos in net_log.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_win.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.cc
===================================================================
--- net/socket_stream/socket_stream.cc (revision 45472)
+++ net/socket_stream/socket_stream.cc (working copy)
@@ -121,7 +121,7 @@
// back before returning Connect().
next_state_ = STATE_RESOLVE_PROXY;
net_log_.BeginEventWithString(NetLog::TYPE_SOCKET_STREAM_CONNECT,
- url_.possibly_invalid_spec());
+ "url", url_.possibly_invalid_spec());
MessageLoop::current()->PostTask(
FROM_HERE,
NewRunnableMethod(this, &SocketStream::DoLoop, OK));
@@ -406,7 +406,8 @@
// close the connection.
if (state != STATE_READ_WRITE && result < ERR_IO_PENDING) {
DCHECK_EQ(next_state_, STATE_CLOSE);
- net_log_.EndEventWithInteger(NetLog::TYPE_SOCKET_STREAM_CONNECT, result);
+ net_log_.EndEventWithInteger(NetLog::TYPE_SOCKET_STREAM_CONNECT,
+ "net_error", result);
}
} while (result != ERR_IO_PENDING);
}
« no previous file with comments | « net/socket/tcp_client_socket_win.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698