cc: Move tracking of layer_property_changed to main thread (3)

cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed, transform_and_invertibility.

This changes the existing behavior. We set
layer_property_changed even when transform is animating on
impl only.

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/865fd48e9c02ced3bdf31c9295008a649bfb06f3
Cr-Commit-Position: refs/heads/master@{#377249}

[jaydasika, 2016-02-20 00:33:12]

Description was changed from

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed

BUG=584512
==========

to

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-02-20 00:56:10]

Description was changed from

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed, transform_and_invertibility.

This changes the existing behavior. We set 
layer_property_changed even when transform is animating on
impl only.

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-02-20 01:03:35]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, enne@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-02-20 01:03:35]

This still doesn't address transform animation on impl. There are two functions
SetTransformAndInvertibility, SetTransform in LayerImpl. The first one is called
only in PushProperties and CL is for that.

[ajuma, 2016-02-22 15:54:40]

https://codereview.chromium.org/1715973002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (left):

https://codereview.chromium.org/1715973002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:691: stacking_order_changed_ = true;
I believe stacking_order_changed_ exists purely for the sake of damage tracking,
so if we're now tracking the change on the main thread, I think
LayerImpl::stacking_order_changed_ can be removed altogether.

[jaydasika, 2016-02-22 18:46:52]

https://codereview.chromium.org/1715973002/diff/20001/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (left):

https://codereview.chromium.org/1715973002/diff/20001/cc/layers/layer_impl.cc...
cc/layers/layer_impl.cc:691: stacking_order_changed_ = true;
On 2016/02/22 15:54:40, ajuma wrote:
> I believe stacking_order_changed_ exists purely for the sake of damage
tracking,
> so if we're now tracking the change on the main thread, I think
> LayerImpl::stacking_order_changed_ can be removed altogether.

Done.

[ajuma, 2016-02-22 20:43:09]

lgtm with one more thing that we can probably delete :)

https://codereview.chromium.org/1715973002/diff/40001/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/1715973002/diff/40001/cc/layers/layer.cc#newc...
cc/layers/layer.cc:294: child->stacking_order_changed_ = true;
Is Layer::stacking_order_changed_ unused now that it isn't being pushed?

[jaydasika, 2016-02-24 07:50:12]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-02-24 07:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1715973002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-24 07:51:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715973002/80001

[commit-bot: I haz the power, 2016-02-24 09:26:22]

Description was changed from

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed, transform_and_invertibility.

This changes the existing behavior. We set 
layer_property_changed even when transform is animating on
impl only.

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed, transform_and_invertibility.

This changes the existing behavior. We set 
layer_property_changed even when transform is animating on
impl only.

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-02-24 09:26:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-24 09:27:53]

Description was changed from

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed, transform_and_invertibility.

This changes the existing behavior. We set 
layer_property_changed even when transform is animating on
impl only.

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move tracking of layer_property_changed to main thread (3)

This is a follow up to http://crrev.com/1697613002
Properties moved in this CL are :
stacking_order_changed, transform_and_invertibility.

This changes the existing behavior. We set
layer_property_changed even when transform is animating on
impl only.

BUG=584512
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/865fd48e9c02ced3bdf31c9295008a649bfb06f3
Cr-Commit-Position: refs/heads/master@{#377249}
==========

[commit-bot: I haz the power, 2016-02-24 09:27:54]

Patchset 5 (id:??) landed as
https://crrev.com/865fd48e9c02ced3bdf31c9295008a649bfb06f3
Cr-Commit-Position: refs/heads/master@{#377249}