Fix nanobench SKP flushes between loops

Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715873002

Committed: https://skia.googlesource.com/skia/+/31c45bbd5a4129b73843872e00b3bd86bd32008f

[Chris Dalton, 2016-02-19 20:26:17]

Description was changed from

==========
Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
==========

to

==========
Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-02-19 20:32:27]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, mtklein@google.com

[Chris Dalton, 2016-02-19 20:32:28]

The flush logic was originally added here:

https://codereview.chromium.org/1427533002

The intent was to flush between draw loops in order to prevent cheat batching,
but that's not what it ended up doing :\

On https://codereview.chromium.org/1541983002/ Brian says:

"Yeah, I think that is a good idea. I think the flush per loop makes sense for
many SKPs because they represent a full frames worth of work. Some SKPs are
really small and more like microbenchs and there it probably makes sense to
allow batching across loops. Or maybe those SKPs should be deleted... or maybe
SKPs should have an inner repeat count that is run loops number of times."

I don't necessarily care if we decide to not flush between loops (there's always
--loopSKP false!) but for the existing flush logic, I'd like to either fix or
remove it.

[mtklein, 2016-02-19 20:35:30]

I strongly have no opinion here.

[joshualitt, 2016-02-22 14:39:07]

On 2016/02/19 20:35:30, mtklein wrote:
> I strongly have no opinion here.

lgtm

[Chris Dalton, 2016-02-22 15:33:12]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-02-22 15:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715873002/1

[commit-bot: I haz the power, 2016-02-22 16:08:27]

Description was changed from

==========
Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/31c45bbd5a4129b73843872e00b3bd86bd32008f
==========

[commit-bot: I haz the power, 2016-02-22 16:08:28]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/31c45bbd5a4129b73843872e00b3bd86bd32008f