Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1427533002: Flush GrContext between benchmark draw loops (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Flush GrContext between benchmark draw loops This change updates a small subset of benchmarks to flush the GrContext between draw loops (specifically SKP benchmarks, SampleApp, and the warmup in visualbench). This helps improve timing accuracy by not allowing the gpu to batch across draw boundaries in the affected benchmarks. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e6d2024c689199b09df0d7048fc5252179d52aff

Patch Set 1 #

Patch Set 2 : Check for SK_SUPPORT_GPU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M bench/SKPBench.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualSKPBench.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Chris Dalton
5 years, 1 month ago (2015-10-26 19:24:29 UTC) #2
joshualitt
On 2015/10/26 19:24:29, Chris Dalton wrote: lgtm
5 years, 1 month ago (2015-10-26 19:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427533002/1
5 years, 1 month ago (2015-10-26 20:03:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3829)
5 years, 1 month ago (2015-10-26 20:04:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427533002/20001
5 years, 1 month ago (2015-10-26 20:34:23 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 20:45:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e6d2024c689199b09df0d7048fc5252179d52aff

Powered by Google App Engine
This is Rietveld 408576698